Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build multiarch thick images #1297

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Conversation

sfackler
Copy link
Contributor

I'm not totally sure why the thick image is different from the thin one here, but it doesn't seem like there should be anything stopping the thick image from being multiarch.

@coveralls
Copy link

Coverage Status

coverage: 63.116%. remained the same
when pulling 572e4e0 on sfackler:thick-arm
into aff99fc on k8snetworkplumbingwg:master.

Copy link
Member

@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can probably move forward as this matches the thin plugin, but, we realized that we don't really have a disclaimer anywhere to say "we don't actually test the other platforms" -- because we just run the e2e tests on x86.

Let's add some text to the development markdown:

https://github.com/k8snetworkplumbingwg/multus-cni/blob/master/docs/development.md

# Multi-arch builds

Multus is currently built for a number of architectures, however, our testing and validation is only performed against x86 architectures. Our x86 architecture has end to end testing, however, for other architectures, only supported via best effort community contributions.

@sfackler
Copy link
Contributor Author

Updated!

Copy link
Member

@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates, appreciate it

@coveralls
Copy link

Coverage Status

coverage: 63.116%. remained the same
when pulling cd81346 on sfackler:thick-arm
into aff99fc on k8snetworkplumbingwg:master.

@dougbtv dougbtv merged commit fd9736b into k8snetworkplumbingwg:master Aug 1, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants