Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we add an explicitly named amd64 release tag? #366

Open
martinkennelly opened this issue Jul 26, 2021 · 5 comments
Open

Can we add an explicitly named amd64 release tag? #366

martinkennelly opened this issue Jul 26, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@martinkennelly
Copy link
Member

Now that #348 is merged.

What would you like to be added?

Add ${GitHub Tag}-amd64 to ensure consistency in our current release tags and aid readability in customer yamls. This tag would point to the same image as tag named "${GitHub tag}".

How?

Modify image-push-release.yml and include ${GitHub Tag}-amd64 tag.

What is the use case for this feature / enhancement?

Allow yaml developers to clearly define the arch of the images.

Images we produce today

Tag Arch Description
latest x86 Latest commit
latest-amd64 x86 Latest commit
${GitHub SHA} x86 Git commit e.g "sha256:540af56cbd92b2dfdaea5bac3c44a6f46a277f0dbed000a0993d116fc377f332"
${GitHub tag} x86 GitHub Release tag e.g "v1.0"
latest-arm64 arm Latest commit
${GitHub tag}-arm64 arm GitHub Release tag e.g "v1.0-arm64"
latest-ppc64le power Latest commit
${GitHub tag}-ppc64le power GitHub Release tag e.g "v1.0-ppc64le"
@martinkennelly martinkennelly added enhancement New feature or request good first issue Good for newcomers labels Jul 26, 2021
@digambar15
Copy link

digambar15 commented Aug 6, 2021

Hi Martin, Can you assign this issue to me? As beginner, this would be right one to start with. Thanks!

@martinkennelly
Copy link
Member Author

@digambar15 Hey! I would say to wait for community feedback on whether we should go ahead with this or not before working on it, but I will assign it to you! Thank you!

@digambar15
Copy link

Sure @martinkennelly

@adrianchiris
Copy link
Contributor

adrianchiris commented Aug 9, 2021

We have it for other Arch, so im fine with making things consistent and having one for amd64 as well.

While we are at it, should ${GitHub tag} image be a manifest which allows the image resitry to pull in the correct platform image ?

@adrianchiris
Copy link
Contributor

This was discussed in K8s NPWG network & resource mgmt meeting on 08.10.2021. this enhancement proposal is approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants