Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloud-config.template里有注释 #20

Closed
wangkuiyi opened this issue Jul 26, 2016 · 4 comments
Closed

cloud-config.template里有注释 #20

wangkuiyi opened this issue Jul 26, 2016 · 4 comments
Assignees
@jiamliang

Comments

@wangkuiyi
Copy link
Contributor

https://github.com/k8sp/auto-install/blob/master/cloud-config-server/template/cloud-config.template#L22

如果是不需要的，应该删除而不是注释
@jiamliang
Copy link
Contributor

恩，这个是疏忽，当时不确定这个是不是必要的设置。
一会马上修改。

@jiamliang
Copy link
Contributor

done.

@wangkuiyi
Copy link
Contributor Author

@jiamliang 上文中的done 是通过 一个PR来done的吗？

@jiamliang
Copy link
Contributor

在同一个PR里面的一次commit里面：
Fixed in 6525df3
我是应该发起多次PR吗？

@jiamliang jiamliang mentioned this issue Jul 27, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiamliang jiamliang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jiamliang @wangkuiyi