Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lens phase function generation #17

Closed
5 tasks
kaanaksit opened this issue Dec 4, 2020 · 2 comments · Fixed by #20
Closed
5 tasks

Lens phase function generation #17

kaanaksit opened this issue Dec 4, 2020 · 2 comments · Fixed by #20
Assignees

Comments

@kaanaksit
Copy link
Owner

kaanaksit commented Dec 4, 2020

odak needs a lens phase function generation routine to generate phase patterns for various lenses (quadratic phase functions). Steps that are required to implement are as follows:

  • Fork odak,
  • In your own fork implement a phase function generation routine in odak.wave specifically in here.
  • Add a test routine with a name test_lens_phase.py to test folder found in here. Other test routines such as this one can help in writing a test routine for this case.
  • Commit all the changes to your fork.
  • Once you are done at your fork, add a pull request to main repository of odak using this link.

Do not hesitate to ask any questions during your implementation.

@kaanaksit
Copy link
Owner Author

Mentioning @praneethc just for visibility.

@kaanaksit kaanaksit self-assigned this Dec 21, 2020
@kaanaksit
Copy link
Owner Author

ae54c05 resolves this issue.

@kaanaksit kaanaksit linked a pull request Dec 25, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant