-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix layouts of lists and content #5
Conversation
Hugo v0.17 was giving errors like this: ERROR: 2016/11/05 20:32:30 template.go:132: template: theme/partials/content.html:8:40: executing "theme/partials/content.html" at <.Site.Params.dateFor...>: invalid value; expected string in theme/partials/content.html Now there are no error and hugo-goa-demo works properly after this commit.
Thank you @sergobot |
@sergobot, this has not fixed the issue. When I tested it locally, the string |
@sergobot The user was missing .dateFormat within their config.toml. |
@shenoybr,
but it didn't work fine before my fix. I have uploaded my screenshots to imgur. By the way, without the fix hugo v0.17 gives errors like the one I copied to PR. And current master branch of hugo says your templates are incorrect:
|
Could you tell me which version of Golang you are using? I tested this on both go 1.6, 1.7.1 and hugo v0.16 and v0.17. The fix you made is incorrect, because it doesn't display the date, and rather displays the string Would there be anything else in the config.toml that is missing? I tested hugo-goa-demo on various platforms, it also works on themes.hugo.io as in here. |
@shenoybr
I have tested hugo-goa-demo with some different hugo versions and here are the results. Really weird results... Without fixWith fixThe weird thingDisappointed by these results, I have also tried building the site with pre-compiled hugo from https://github.com/spf13/hugo/releases. Screenshots going below are made without my fix, since the fix doesn't make any difference compared to self-built versions of hugo. So, actual explanation seems to be one of |
@sergobot Thank you for this detailed investigation into the issue. I agree that it does look like it might have something to do with self-built hugo or the environment it is running in. I'll try and run it this weekend to understand why it could happen. |
@shenoybr Hi, how is your investigation going? |
Okay, I have fixed it. Check out #10 |
Hugo v0.17 was giving errors like this:
ERROR: 2016/11/05 20:32:30 template.go:132: template: theme/partials/content.html:8:40: executing "theme/partials/content.html" at <.Site.Params.dateFor...>: invalid value; expected string in theme/partials/content.html
Now there are no errors and hugo-goa-demo works properly after this commit. Also, it seems to be solution for #4.