Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS Feed #9

Closed
adidalal opened this issue Apr 25, 2015 · 3 comments
Closed

RSS Feed #9

adidalal opened this issue Apr 25, 2015 · 3 comments

Comments

@adidalal
Copy link

The feed title and all posts get wrapped in extraneous <![CDATA[ and ]]> tags. Tested on latest Firefox in Windows 8.1.

Imgur

/rss/ source:

<?xml version="1.0" encoding="UTF-8"?><rss version="2.0">
  <channel>
    <title>&lt;![CDATA[My Blog]]&gt;</title>
    <link></link>
    <description>&lt;![CDATA[Just another Blog]]&gt;</description>
    <pubDate>25 Apr 15 15:41 EDT</pubDate>
    <item>
      <title>&lt;![CDATA[Hello World]]&gt;</title>
      <link>/hello-world</link>
      <description>&lt;![CDATA[&lt;p&gt;&lt;strong&gt;Test&lt;/strong&gt;&lt;br /&gt;&#xA;Markdown here&lt;/p&gt;&#xA;]]&gt;</description>
      <author>Aditya</author>
      <guid>8e5b0b49-7c5d-4789-b64e-271cb9018c5e</guid>
      <pubDate>25 Apr 15 19:18 UTC</pubDate>
    </item>
  </channel>
</rss>
@kabukky
Copy link
Owner

kabukky commented Apr 25, 2015

Hi adityadalal924,
that is intentional, I wanted to mirror Ghosts behavior here: dylang/node-rss#27
But as that issue says, it's not really necessary for most strings. So I'm going to change it in the next release: CDATA will only be used when the string includes a character that warrants it :)

@tomkwok
Copy link
Contributor

tomkwok commented May 2, 2015

@kabukky Take a look at the RSS output.

<description>&lt;![CDATA[Just another Blog]]&gt;</description>

The < and > got escaped, so &lt;![CDATA[ and ]]&gt; is output.

@kabukky
Copy link
Owner

kabukky commented May 7, 2015

Fixed in 694508b

@kabukky kabukky closed this as completed May 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants