-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardizing JS and JSX style? #23
Comments
I would have to immediately disagree with using that set of standardization rules. I use eslint to catch the things I am interested in and I don't need someone else's rules. |
I think this is very useful for projects that have remote devs or even large projects that need some standard styling. Of course, different projects have different rules and standards. So this might not be applicable to some projects. I'm suggesting this because one of Mantra's aims is to have high maintainability and I think this could make mantra more maintainable. |
I think having .eslint is pretty important since it can be used with a lot of tools. Current version of eslint is based Facebook's some public repos. That's a pretty strict(much better than airbnb) and good set of rules. I follow them in even our private projects. |
Yes, I have no problem with a set of eslint rules. |
I think this is a touchy subject. Code style is something that people take very personally, and I don't think that any project should be too forceful regarding the nit-picky details of how code is formatted. I would hate to lose support for this awesome spec just because people bicker about which rules to include. I'm sure we could come up with a baseline Here's my current eslint config as a reference for what I use: https://gist.github.com/natecox/1fca34cba9e4a80b2156 |
I think what we could say is that within a project a consistent style is very helpful for avoiding simple bugs and that it also makes it easier for new people to get up to speed. Then we can provide a list of tools such as ESlint and perhaps suggest some coding standards that have worked well on large projects, followed by Rule 0. |
I'm going to close this since we are already using eslint with some good configuration. |
Since Mantra is already introducing a set of standards for Meteor apps. Maybe you can also add feross/standard to introduce JS and JSX style standard to make it more maintainable?
The text was updated successfully, but these errors were encountered: