-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrections to get build checks passed #386
Conversation
It would be nice if someone could fix the elvis breakage... |
@mikpe As a repo owner you can force merge this PR, then deal with elvis checks separately |
Thanks for the PR! Alternatively, this dependency can be fetched from hex: https://hex.pm/packages/snabbkaffe |
Ah thanks, I didn't want to change the source in case there was a reason for it. |
Hi!
I don't think there is a good reason to keep this dependency as a source. If I remember correctly, this package hadn't been published to Hex at the time.
I guess both PRs are needed to get a green build. Order should not be important. |
This avoids breakage due to test framework development.
The latest elvis is using a new version of katana_code, which has replaced the pre-processor handling, see: inaka/katana-code#31 This has changed the behavior of elvis to also check code defined in TEST scope.
5436ce6
to
008ae39
Compare
Pull Request Test Coverage Report for Build 1365
💛 - Coveralls |
Sound reasonable and I changed this..much better.
Since its was two small PRs I merged them into this, seems that I got a coverage run now atleast. |
Thank you! |
Pin version of test dependency snabbkaffe
This avoids breakage due to test framework development,
and will enable the common test suites again.
Update test to please DRY rule check in elvis
This corrects an issue found during the Travis build, from #385
When Travis is running it uses the latest version of rebar3 and elvis,
but the latest elvis has a change regarding how it handles macros.
Elvis depends on katana_code, which has replaced the pre-processor handling, see:
inaka/katana-code#31
This has changed the behavior of elvis to also include code defined in TEST scope in its checks,
which this PR simply fixes.
This could also be solved by pinning elvis to a specific older version..