[#26] Drop aleppo and use a forked epp_dodger #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After adding a test that tries to parse all OTP .erl files, there were some issues found with some modules. These issues are addressed by either ignoring unparsable code and/or replacing it with dummy values.
elbrujohalcon
approved these changes
Nov 29, 2019
|
I think you need to push changes to rebar.lock as well. |
elbrujohalcon
requested changes
Nov 29, 2019
|
@elbrujohalcon Yes, I missed that, I will add it to the PR. I also need to remove |
|
The elvis check in |
bjosv
added a commit
to Nordix/brod
that referenced
this pull request
Apr 14, 2020
The latest elvis is using a new version of katana_code, which has replaced the pre-processor handling, see: inaka/katana-code#31 This has changed the behavior of elvis to also check code defined in TEST scope.
bjosv
added a commit
to Nordix/brod
that referenced
this pull request
Apr 20, 2020
The latest elvis is using a new version of katana_code, which has replaced the pre-processor handling, see: inaka/katana-code#31 This has changed the behavior of elvis to also check code defined in TEST scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the issues around macros have been caused by the fact that we are using the aleppo library to reproduce the behaviour of the erlang pre-processor but applied to text instead of files.
Recent work on erlang-ls has shown that using the
epp_dodgermodule, could be a more robust approach. Sadly this module doesn't provide a lot of configuration of customization throught its API, therefore this PRs "forks" it so that the parsed forms include the text in their nodes.I ran elvis_core's tests with these changes and I have a branch where all tests pass with minimal changes.
Fixes #26.