Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and future maintenance #20

Open
7 tasks
imcrazytwkr opened this issue Jan 18, 2019 · 0 comments
Open
7 tasks

Refactoring and future maintenance #20

imcrazytwkr opened this issue Jan 18, 2019 · 0 comments

Comments

@imcrazytwkr
Copy link
Contributor

I'm still using the old version of Cookie monster in some of my projects but the version 0.2.1 is fairly outdated and non-maintained. I'd like to refactor it in a proper ES6 format and bundle it into different formats using Rollup. If you give me an ok, I'll prepare the pull request for version 1.0. Additionally, I'm also interested in maintaining the package since, well, I'm using it already and had contributed to it in the past.

Change proposal:

  • Refactor to ES6
  • Expose cookie-monster class instead of an instance that is implicitly initialised with global document object
  • Deprecate legacy .get(), .set() and .remove() methods
  • Implement .key(n) method and .length property to completely conform to localStorage API
  • Add argument type checks to .getItem() and .removeItem()
  • Use Rollup + Buble to build modules in all necessary formats (ESM, commonjs and universal)
  • Replace Karma + Mocha + Chai bundle with Jest for testing to decrease the number of explicit development dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant