Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jll version; update readme; do code formatting #28

Merged
merged 3 commits into from
Nov 26, 2023

Conversation

jalving
Copy link
Member

@jalving jalving commented Nov 20, 2023

This should update the Julia interface to use the v1.3.3 release. It also does some code formatting and adds a quick usage example to the README. All source and test file changes are a result of running Julia formatter with BlueStyle.

@codecov-commenter
Copy link

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (a4f967f) 85.95% compared to head (e00fd4e) 84.55%.

Files Patch % Lines
src/kahypar_h.jl 70.58% 10 Missing ⚠️
src/KaHyPar.jl 88.57% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   85.95%   84.55%   -1.40%     
==========================================
  Files           2        2              
  Lines         121      123       +2     
==========================================
  Hits          104      104              
- Misses         17       19       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jalving
Copy link
Member Author

jalving commented Nov 20, 2023

@SebastianSchlag feel free to merge this. (By the way, I can update Julia interface once kahypar v1.3.4 gets released).

@mofeing: this should now hit the v1.3.3 binaries you updated

@SebastianSchlag SebastianSchlag merged commit bea720d into kahypar:master Nov 26, 2023
4 checks passed
@SebastianSchlag
Copy link
Member

Thanks @jalving! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants