Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve grouping feature in EmbeddingsWriter #376

Closed
Tracked by #360
nkaenzig opened this issue Apr 17, 2024 · 0 comments
Closed
Tracked by #360

Improve grouping feature in EmbeddingsWriter #376

nkaenzig opened this issue Apr 17, 2024 · 0 comments
Assignees

Comments

@nkaenzig
Copy link
Collaborator

For slide level tasks, we should use group_key to group patches from the same slide into the same .pt file(s).
The way it is implemented now still generates one file per patch. We probably should accumulate patches in memory over multiple batches before saving them to file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant