Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to perform GET on full list of continent objects #60

Closed
netman2048 opened this issue Dec 6, 2021 · 1 comment
Closed

Unable to perform GET on full list of continent objects #60

netman2048 opened this issue Dec 6, 2021 · 1 comment
Assignees
Labels

Comments

@netman2048
Copy link

Trying to do an fmc.object.continent.get() to get the full list of continents however it fails because the PATH in the Continent object is incorrect. The URL has continent as plural.

fireREST code

from fireREST.fmc import Resource


class Continent(Resource):
    PATH = '/object/continent/{uuid}'
    MINIMUM_VERSION_REQUIRED_GET = '6.1.0'

Corrected code

from fireREST.fmc import Resource


class Continent(Resource):
    PATH = '/object/continents/{uuid}'
    MINIMUM_VERSION_REQUIRED_GET = '6.1.0'

I tested this change and it pulled the continents fine.

kaisero pushed a commit that referenced this issue Feb 19, 2022
@kaisero kaisero self-assigned this Feb 19, 2022
@kaisero kaisero added the bug label Feb 19, 2022
@kaisero
Copy link
Owner

kaisero commented Feb 19, 2022

Thank you for reporting this issue - I've been a bit busy in the last few months. v1.0.10 will fix this problem

@kaisero kaisero mentioned this issue Feb 19, 2022
kaisero added a commit that referenced this issue Feb 19, 2022
# 1.0.10 [2022-02-19]

## Fixed

* incorrect api endpoint for object.dynamicobject (#57, #64). thanks @dheule for providing a fix
* missing refs in devicerecord for physicalinterface (#61)
* incorrect api endpoint for object.continent (#60)
* uuid check issues with object.applicationcategory (#59)
* removed incorrect delete calls for device.devicerecord.redundantinterface
* removed incorrect delete calls for device.devicerecord.subinterface
* removed incorrect delete calls for device.devicerecord.virtualswitch
* removed incorrect delete calls for device.devicerecord.virtualtunnelinterface
* removed incorrect delete calls for device.devicerecord.vlaninterface
@kaisero kaisero closed this as completed Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants