Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should I train audio with 24k and 44.1k sampling rates? #2

Open
accum-dai opened this issue May 7, 2024 · 1 comment
Open

How should I train audio with 24k and 44.1k sampling rates? #2

accum-dai opened this issue May 7, 2024 · 1 comment

Comments

@accum-dai
Copy link

accum-dai commented May 7, 2024

It seems that the model upsamples based on the hop_size, so training audio at 24k and 44.1k should be the same as training 22050 Hz audio; I just need to modify the sampling rate settings in params.py. However, I'm not quite sure about one thing. Do I need to modify this function?

def remove_cutoff_frequency(signal):
    signal = torchaudio.functional.highpass_biquad(
        signal, sample_rate=22050 // 2, cutoff_freq=15
    )
    signal = torchaudio.functional.lowpass_biquad(
        signal, sample_rate=22050 / 2, cutoff_freq=5500
    )
    return signal
@signofthefour
Copy link
Collaborator

@accum-dai Sorry for late reply!
This function is necessary for removing aliasing at the cut-off frequency. While it is only required for post-processing and not for training, I recommend using it to slightly enhance the output quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants