Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags URL is invalid, when baseURL = "/" #16

Closed
Vectorrent opened this issue Nov 3, 2022 · 2 comments · Fixed by #17
Closed

Tags URL is invalid, when baseURL = "/" #16

Vectorrent opened this issue Nov 3, 2022 · 2 comments · Fixed by #17
Labels
good first issue Good for newcomers

Comments

@Vectorrent
Copy link
Contributor

I need to publish my site at multiple domains. To do this, I simply specify the following in my config.toml:

baseURL = "/"

This works great across my other sites, using other themes, and it mostly works in HugoTeX, as well.

However, tag URLs are invalid. When I click on the "games" tag, for example, I'm taken to the following URL:

https://tags/games/

Obviously, that doesn't work.

Anyway, this is a low priority issue, and not something that affects me much, at the moment. I just thought I'd let you know!

Thanks for creating such an awesome theme!

@kaisugi
Copy link
Owner

kaisugi commented Nov 4, 2022

Thank you for pointing this out.
I have no idea how to solve this issue, but I would like to merge fix PR asap if you can create one, thanks!

@kaisugi kaisugi added the good first issue Good for newcomers label Nov 4, 2022
@Vectorrent
Copy link
Contributor Author

Just pushed a PR that addresses this issue. Not sure if it's a "good" fix, but it's worked for me, in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants