Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Adobe Photoshop (PSD) file format #138

Open
davidhicks opened this issue May 3, 2017 · 5 comments · May be fixed by #545
Open

Add Adobe Photoshop (PSD) file format #138

davidhicks opened this issue May 3, 2017 · 5 comments · May be fixed by #545

Comments

@davidhicks
Copy link
Contributor

Official specification of the Adobe Photoshop (.psd) file format: https://www.adobe.com/devnet-apps/photoshop/fileformatashtml/

Work in progress branch for implementing a Kaitai Struct format specification for .psd: https://github.com/davidhicks/kaitai_struct_formats/tree/psd

@davidhicks
Copy link
Contributor Author

Status update on the draft ksy specification:

  • most features of the file format which are officially specified have already been implemented in the draft ksy specification
  • one of the fields of the file format pulls in an ICC (version 4 I think) file, and I can't work out how to get https://ide.kaitai.io to find the existing icc_4.ksy file in the official formats repository using the import syntax
  • there could be a bug where the draft spec tries to define an infinite recursive data structure related to the descriptor_resource type (commonly used data structure within the Photoshop format)
  • I haven't yet seen a need for additional features to be added to Kaitai Struct before this file format specification is completed

@GreyCat
Copy link
Member

GreyCat commented May 3, 2017

We had an idea of alternative one-repo-per-file-format development model for bigger, more important formats that require lots of careful planning, testing, storing samples, etc, etc.

Generally, under this model, development of such "big" formats happens in separate repo that gets merged into kaitai_struct_formats periodically.

I guess I shall create a separate issue for disucssion of this approach, and I totally want to invite you to try it with Photoshop file format project. This should aid collaboration on such non-trivial formats immersively.

@GreyCat
Copy link
Member

GreyCat commented May 3, 2017

Ok, here we go: kaitai-io/kaitai_struct#165

@GreyCat GreyCat transferred this issue from kaitai-io/kaitai_struct Apr 27, 2019
@GreyCat
Copy link
Member

GreyCat commented Aug 17, 2019

Alternative PSD spec implementation from @ertaquo:

https://gist.github.com/ertaquo/b1d12c37a21268e3d095d39e196f5863

@KOLANICH KOLANICH linked a pull request Nov 8, 2021 that will close this issue
@KOLANICH
Copy link
Contributor

KOLANICH commented Nov 8, 2021

@generalmimon generalmimon linked a pull request Nov 9, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants