Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

Windows version build fails due to improper symbolic link #110

Closed
futchitwo opened this issue Jul 22, 2021 · 2 comments
Closed

Windows version build fails due to improper symbolic link #110

futchitwo opened this issue Jul 22, 2021 · 2 comments
Labels
area:ci/cd Issues related to circular integration/deployment bug Something isn't working platform:windows This issue targets Windows-only

Comments

@futchitwo
Copy link

Windows build fails due to improper symbolic links.

The symbolic link should be a relative path, as in the following version.
https://github.com/Craftplacer/Kaiteki/blob/351bcdd72ae6f6f7cdfc1072080267a5aba0a0cf/src/kaiteki/windows/runner/resources/app_icon.ico

In the current version, it is an absolute path, which means that the file cannot be found outside of your environment.
https://github.com/Craftplacer/Kaiteki/blob/master/src/kaiteki/windows/runner/resources/app_icon.ico

@futchitwo futchitwo changed the title Windows build fails due to improper symbolic link Windows version build fails due to improper symbolic link Jul 22, 2021
@Craftplacer Craftplacer added area:ci/cd Issues related to circular integration/deployment platform:windows This issue targets Windows-only bug Something isn't working labels Jul 22, 2021
@Craftplacer
Copy link
Member

Good catch, I'll look into it.

@Craftplacer
Copy link
Member

Yep, that did the trick. I will look into making the builds not count as "failed" when only the MSIX packaging step failed as we still have the build artficats. Thanks for pointing it out again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:ci/cd Issues related to circular integration/deployment bug Something isn't working platform:windows This issue targets Windows-only
Projects
Archived in project
Development

No branches or pull requests

2 participants