Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AOE Spells Are Broken Wont Roll Damage #1131

Closed
dmportella opened this issue Jun 4, 2024 · 2 comments
Closed

AOE Spells Are Broken Wont Roll Damage #1131

dmportella opened this issue Jun 4, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@dmportella
Copy link
Contributor

dmportella commented Jun 4, 2024

Describe the bug
When trying to cast fireball or cloud of dagger for example, the event just opens the side bar and does not roll the damage.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Spells
  2. Click on Fireball Damage
  3. See error on Console.

Expected behavior
Dice to be rolled and damaged to be calculated

Screenshots
image

Browser Info (please complete the following information):

  • Browser [chrome]
  • Version [125.0.6422.142 ]
  • If applicable, any dev console errors (F12 to open the console) from D&D Beyond and the VTT
    Added in additional Context

Additional context
Line of the code is where the Range and Area are split
The Properties are undefined.
image

Current Version of the Extension
image

DND BEYOND VERSION
Version:
@dndbeyond/character-app@1.59.3

Browser Version
image

It Seems that propertyListToDict function is failing to extract the properties of the spell returning a empty properties array.

the lines :

        labelElement = prop.children().filter((i, el) => el.className.includes("Label"));
        valueElement = prop.children().filter((i, el) => el.className.includes("Value"));

The ClassNames are now in lower case, consider changing this so it is case insensitive.

image

@dmportella dmportella added the bug Something isn't working label Jun 4, 2024
@dmportella
Copy link
Contributor Author

fixed by #1133

@dmportella
Copy link
Contributor Author

all is working now <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant