Implementing Rocket Booking #43
Conversation
There was a problem hiding this comment.
Hi @tsheporamantso ,
CHANGES REQURED ♻️
Highlights
- All Linters check passed 👍
- Correct Gitflow followed 👍
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| description={rocket.description} | ||
| image={rocket.image[0]} |
There was a problem hiding this comment.
The image for the first rocket is not loading, kindly fix that.
There was a problem hiding this comment.
Thank you for the suggestion, not sure why that's happening because all images are showing on my computer.
There was a problem hiding this comment.
Hi @tsheporamantso
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- Nice implementation of design
- No linter errors
CHANGES REQUIRED ♻️
Please check the comment below for changes.
There was a problem hiding this comment.
Great job, now the first rocket image is correctly displayed. 🎆 🥂
However, there is still an issue with the styles of the reserved button and the cancel reservation button: the content of the cancel reservation button should not be unbook rocket but rather cancel reservation.
Kindly fix this issue. Here is how it should look coming from the project requirement.
There was a problem hiding this comment.
Thank you for pointing that out, but the styling is handled on my next task. Can we please meet on Zoom and discuss this further.
There was a problem hiding this comment.
STATUS: APPROVED 🎉 👏 🍾
Hi @tsheporamantso ,
There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Highlights 👏 🎩
No linter errors 👍
Good use of Gitflow 👍
Used useSelector to select state👍
Optional suggestions 🛩️
N/A
On this milestone, the following changes were implemented: