Use KALDI_ROOT env if it's initialized #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpovey
reviewed
Oct 11, 2017
egs/csj/s5/local/csj_train_lms.sh
Outdated
| @@ -50,9 +50,9 @@ done | |||
| loc=`which ngram-count`; | |||
| if [ -z $loc ]; then | |||
| if uname -a | grep 64 >/dev/null; then # some kind of 64 bit... | |||
| sdir=`pwd`/../../../tools/srilm/bin/i686-m64 | |||
| sdir=${KALDI_ROOT:-`pwd`/../../..}/tools/srilm/bin/i686-m64 | |||
There was a problem hiding this comment.
i think it would make more sense to have the script source path.sh
(. ./path.sh)
and then jsut use ${KALDI_ROOT} with no backoff to ../../../.
There was a problem hiding this comment.
Thank you for your advice.
Looks good to me.
|
Should I squash commits? |
danpovey
reviewed
Oct 11, 2017
egs/csj/s5/local/csj_train_lms.sh
Outdated
| @@ -42,6 +42,7 @@ fi | |||
| text=$1 | |||
| lexicon=$2 | |||
| dir=$3 | |||
| . path.sh | |||
There was a problem hiding this comment.
do . ./path.sh
(in case there is a path.sh in a directory on the current PATH, or . is not on the path).
no need to squash
I'll merge to-morrow
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous script, used relative PATH that used
pwd.When cloning only CSJ-recipe for tuning it, it is hard to keep the directory structure.
IMO, we should use KALDI_ROOT env that initialized in
path.shinstead ofpwd's relative path.