[src] Make CachingOptimizingCompiler thread safe. Thx: Arseniy Gorin #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpovey
force-pushed
the
compiler_thread_safe
branch
from
a8b1fc1
to
e4da298
Compare
|
You can add thread safety but right now if a kernel does a Malloc as the same time as user space, the gpu will deadlock |
|
This code isn't really intended for use with GPUs.
In any case I'm not sure what you mean-- perhaps there is some bug in a
particular version of the CUDA library that you are talking about. CUDA is
definitely supposed to support multi-threaded programs.
…On Sat, Mar 17, 2018 at 7:22 PM, btiplitz ***@***.***> wrote:
You can add thread safety but right now if a kernel does a Malloc as the
same time as user space, the gpu will deadlock
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2288 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADJVu57526JnXdWvgJaQVOmmrlWE9gq6ks5tfZrCgaJpZM4Su-z3>
.
|
|
Oh I misread the comment. Ignore what I said |
gorinars
reviewed
Mar 22, 2018
| @@ -248,7 +248,7 @@ void DecodableNnetSimple::DoNnetComputation( | |||
| request.outputs.resize(1); | |||
| request.outputs[0].Swap(&output_spec); | |||
|
|
|||
| const NnetComputation *computation = compiler_.Compile(request); | |||
| std::shared_ptr<const NnetComputation> computation = compiler_.Compile(request); | |||
There was a problem hiding this comment.
please apply the same fix in nnet3-xvector-compute.cc:47
LvHang
pushed a commit
to LvHang/kaldi
that referenced
this pull request
Apr 14, 2018
…aldi-asr#2288) Conflicts: src/nnet3/nnet-optimize-utils.cc src/nnet3/nnet-optimize.cc
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.