added utils/combine_ali_dirs.sh (fixes #553). #725
Conversation
|
@vimalmanohar could you please review. |
| done | ||
|
|
||
| for f in final.mdl tree cmvn_opts splice_opts num_jobs $extra_files; do | ||
| if [ ! -f $first_src/$f ]; then |
There was a problem hiding this comment.
not all of these files are required in all recipes, e.g. I'm not sure that splice_opts is required in nnet3. I would just assume this whole list is optional, and add in whatever you can think of here that we might want to copy over, including final.mat and subsampling_factor [just off the top of my head.]
|
@vijayaditya and @vimalmanohar, I think you were reviewing this? Is it good to commit? |
|
I think it looks good to commit. |
| . parse_options.sh || exit 1; | ||
|
|
||
| if [[ $# -lt 3 ]]; then | ||
| echo "Usage: $0 [options] <ref-data-dir> <dest-ali-dir> <src-ali-dir1> <src-ali-dir2> ..." |
There was a problem hiding this comment.
Just call this <data> and in the code call it data, not ref_data_dir. This is the normal pattern; in some sense, it's always for reference.
|
@xiaohui-zhang Is this ready for review ? |
|
@xiaohui-zhang, please have a look at this. I think you didn't address my latest comments. |
|
sorry! will do it soon.
|
|
done |
| utils/split_data.sh $data $num_jobs || exit 1; | ||
| echo $num_jobs > $dest/num_jobs || exit 1 | ||
|
|
||
| echo "$0: spliting the alignments to appropriate chunks according to the reference utt2spk files." |
|
fixed |
|
OK but please rebase into one commit. |
|
done |
No description provided.