Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add approval calls into dao deployment #24

Closed
z0r0z opened this issue Jan 27, 2022 · 1 comment
Closed

add approval calls into dao deployment #24

z0r0z opened this issue Jan 27, 2022 · 1 comment

Comments

@z0r0z
Copy link
Member

z0r0z commented Jan 27, 2022 •
edited
Loading

if redemption extension is selected in deployment, we should add approval calls.

extensions: TOKEN
extensionData: APPROVE(extension, uint256max)
@z0r0z
Copy link
Member Author

z0r0z commented Jan 27, 2022

this allows redemption extension to pull DAO treasury tokens when users ragequit immediately on deployment. If this is a concern for users, they can always set a later redemption time.

@z0r0z z0r0z closed this as completed Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@z0r0z