Skip to content

Commit

Permalink
fix: update env (docs and namespace)
Browse files Browse the repository at this point in the history
  • Loading branch information
Dan Ziv committed Jan 9, 2018
1 parent dd06d82 commit c2b016b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,12 @@ Finally, add the bundle as a script tag in your page, and initialize the player
```html
<script type="text/javascript" src="/PATH/TO/FILE/playkit.js"></script>
<script type="text/javascript" src="/PATH/TO/FILE/playkit-dash.js"></script>
<div id="videoContainer" style="height:360px; width:640px">
<div id="player-placeholder" style="height:360px; width:640px">
<script type="text/javascript">
var playerContainer = document.querySelector("#player-placeholder");
var config = {...};
var player = playkit.loadPlayer("videoContainer", config);
var player = playkit.core.loadPlayer(config);
playerContainer.appendChild(player.getView());
player.play();
</script>
```
Expand Down
2 changes: 2 additions & 0 deletions karma.conf.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
let webpackConfig = require('./webpack.config.js');
//Need to remove externals otherwise they won't be included in test
delete webpackConfig.externals;
// Need to define inline source maps when using karma
webpackConfig.devtool = 'inline-source-map';

const isWindows = /^win/.test(process.platform);
const isMacOS = /^darwin/.test(process.platform);
Expand Down
2 changes: 1 addition & 1 deletion webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ module.exports = {
output: {
path: __dirname + "/dist",
filename: '[name].js',
library: "PlaykitJsDash",
library: ["playkit", "dash"],
libraryTarget: "umd",
devtoolModuleFilenameTemplate: "./dash/[resource-path]",
},
Expand Down

0 comments on commit c2b016b

Please sign in to comment.