Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: downgrade shaka dependencies #113

Merged
merged 2 commits into from
Aug 5, 2020
Merged

fix: downgrade shaka dependencies #113

merged 2 commits into from
Aug 5, 2020

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Aug 5, 2020

Description of the Changes

issue: version 3.0.x has an issue with some dash streams.
solution: downgrade to 2.5.13.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke
fix: downgrade shaka dependencies
3de8081 
issue: version 3.0.x has an issue with some dash streams.
solution: downgrade to 2.5.13.
@Yuvalke Yuvalke requested a review from OrenMe August 5, 2020 13:27
@Yuvalke Yuvalke self-assigned this Aug 5, 2020
OrenMe
OrenMe previously approved these changes Aug 5, 2020
View reviewed changes
@Yuvalke Yuvalke merged commit af69a03 into master Aug 5, 2020
@Yuvalke Yuvalke deleted the downgrade-shaka branch August 5, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

@OrenMe OrenMe OrenMe left review comments

Assignees

@Yuvalke Yuvalke

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yuvalke @OrenMe @yairans