feat(FEC-10941): Use In-Stream DASH thumbnails on the timeline #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairans
reviewed
Mar 9, 2021
| @@ -17,8 +17,7 @@ class DashThumbnailController { | |||
| } | |||
|
|
|||
| selectTrack(track: ImageTrack): void { | |||
| this._tracks.forEach((t: ImageTrack) => (t.active = false)); | |||
| track.active = true; | |||
| this._tracks.forEach((t: ImageTrack) => (t.index === track.index ? (t.active = true) : (t.active = false))); | |||
There was a problem hiding this comment.
what's the diff here? track is not passed by ref?
There was a problem hiding this comment.
right (it should be).
There was a problem hiding this comment.
it should be but is not? how?
There was a problem hiding this comment.
I meant it *shouldn't :)
yairans
approved these changes
Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.
CheckLists