fix(FEC-7451): video does not play after pressing play #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we already call it in the play method.
odedhutzler
changed the title
OrenMe
suggested changes
Dec 21, 2017
| reject(e); | ||
| } | ||
| }).then(() => { | ||
| try { |
There was a problem hiding this comment.
@odedhutzler The try catch was there to protect against the nested player accessor I think, please check if still required.
Otherwise, LGTM.
OrenMe
previously approved these changes
Dec 28, 2017
checking regarging auto preload, the ready state only concerns this situation.
OrenMe
previously approved these changes
Jan 1, 2018
dan-ziv
suggested changes
Jan 1, 2018
| @@ -126,6 +114,7 @@ class PrePlaybackPlayOverlay extends BaseComponent { | |||
| if ((!props.isEnded && !props.prePlayback) || (!props.isEnded && this.autoplay)) { | |||
| return undefined; | |||
| } | |||
| let playerIsReady = this.player.config.playback.preload === "auto" ? this.state.isPlayerReady : true; | |||
There was a problem hiding this comment.
use const
why state name is isPlayerReady and var name is playerIsReady?
There was a problem hiding this comment.
changed to const + naming, thanks
dan-ziv
approved these changes
Jan 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed duplicate call to the ready promise.
It seems calling play would be enough in case of preload: 'auto'. if the video is not loaded yet - then it will be handled in the player.js
CheckLists