fix(FEC-10289): controls disappear using keyboard #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: there are multiple timeout which could be with different timing to handle disappearing of ui, so there are cases that it makes wrong behivaour. Solution: handle ui disappearing in shell only.
dan-ziv
reviewed
Sep 7, 2020
Yuvalke
requested review from
a team
and removed request for
OrenMe,
yairans and
RoyBregman
OrenMe
approved these changes
Oct 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue: there are multiple timeouts that could be with different timing to handle the disappearing of UI, so there are cases that it makes the wrong behavior.
The new keyboard handler doesn't change the hover state.
Solution: handle UI disappearing in shell only
Change the hover state on new keyboard handler as it was on the previous one.
CheckLists