Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update XmlClientGenerator.php #8417

Merged
merged 2 commits into from
May 19, 2019
Merged

Update XmlClientGenerator.php #8417

merged 2 commits into from
May 19, 2019

Conversation

hilak
Copy link
Contributor

@hilak hilak commented May 13, 2019

No description provided.

MosheMaorKaltura
MosheMaorKaltura reviewed May 14, 2019
View reviewed changes
Copy link
Contributor

@MosheMaorKaltura MosheMaorKaltura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If plugin is empty, can we avoid adding the attribute?

@hilak
Copy link
Contributor Author

hilak commented May 17, 2019

@MosheMaorKaltura I've removed the argument in case the pluginName is empty, and also the creation of the 'prefix' var which appear completely unused. Please review and merge if acceptable

@MosheMaorKaltura MosheMaorKaltura merged commit eb1f081 into Orion-15.0.0 May 19, 2019
@MosheMaorKaltura MosheMaorKaltura deleted the Orion-15.0.0-generationWarnFix branch May 19, 2019 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MosheMaorKaltura MosheMaorKaltura MosheMaorKaltura left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hilak @MosheMaorKaltura