Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUP-19231 - email notification fix to handle more than 150 users when… #8764

Merged
merged 2 commits into from Sep 11, 2019

Conversation

@gotlieb
Copy link
Contributor

commented Sep 11, 2019

… filerting with idIn due to sphinx limitations.

@MosheMaorKaltura

… filerting with idIn due to sphinx limitations.
$pager->pageIndex ++;
}
while ($pager->pageSize == count($userList->objects));
while (($pager->pageSize == count($categoryUserList->objects)) and ($pager->pageIndex <= $maxPagesToScan));

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Sep 11, 2019

Contributor

Better remove this check - ($pager->pageSize == count($categoryUserList->objects)

  1. Since you already check if response empty.
  2. It is possible that 1 categoryUser will be removed during the response.

This comment has been minimized.

Copy link
@gotlieb

gotlieb Sep 11, 2019

Author Contributor

ok

$maxPagesToScan = 2;
$userPager = new KalturaFilterPager();
$userPager->pageSize = $pager->pageSize;
$maxPagesToScan = 7;

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Sep 11, 2019

Contributor

The former procedure tried to handle 1000 users, why block at 700

This comment has been minimized.

Copy link
@gotlieb

gotlieb Sep 11, 2019

Author Contributor

fixed to 1050

@gotlieb gotlieb merged commit 8b45c09 into Orion-15.7.0 Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.