Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-10466 - handle invalid chars for partner describeYourself field #9073

Merged
merged 2 commits into from Dec 29, 2019

Conversation

@gotlieb
Copy link
Contributor

gotlieb commented Dec 29, 2019


if ($this->describeYourself && (strlen ($this->describeYourself) > self::MAX_DESCRIBE_YOURSLEF_LEN))
{
$this->describeYourself = kString::alignUtf8String($this->describeYourself, 64);

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Dec 29, 2019

Contributor
  1. Use const here (instead of 64)
  2. Apply this fix to all the relevant fields that can have an issue here.
@@ -428,8 +430,7 @@ public function toPartner()
$this->validatePartnerPackageForInsert();
$this->validateForInsert();

$partner = new Partner();
$partner = parent::toObject( $partner );
$partner = parent::toObject();

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Dec 29, 2019

Contributor

this should be changed to $this->toObject() isn't it?

@gotlieb gotlieb merged commit 964e36f into Orion-15.14.0 Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.