Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REACH2-857:Import catalog item csv from admin console #9424

Merged
merged 4 commits into from
May 20, 2020

Conversation

ravitshalem
Copy link
Contributor

@ravitshalem ravitshalem commented May 18, 2020

This change is Reviewable

}
catch (Exception $e)
{
KalturaLog::err('Error in vendorCatalogItem->addFromBulkUpload ' . $e->getMessage());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens in case of error ? what do u see in the screen?
might want to add something like .... $action->view->errMessage = $e->getMessage(); .... and show it in the admin console.

try
{
$bulkUploadResult = $reachPluginClient->vendorCatalogItem->addFromBulkUpload($csvPath);
$bulkUploadId = $bulkUploadResult->id;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once done - delete the file $csvPath

@ravitshalem ravitshalem merged commit 16052c5 into Propus-16.3.0 May 20, 2020
@ravitshalem ravitshalem deleted the Propus-16.2.0-REACH2-857 branch May 20, 2020 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants