nathelper: add optional set_contact_alias([trim]) parameter

[eschmidbauer]

Pre-Submission Checklist

• Commit message has the format required by CONTRIBUTING guide
• Commits are split per component (core, individual modules, libs, utils, ...)
• Each component has a single commit (if not, squash them into one commit)
• No commits to README files for modules (changes must be done to docbook files
  in doc/ subfolder, the README file is autogenerated)

Type Of Change

• Small bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds new functionality)
• Breaking change (fix or feature that would change existing functionality)

Checklist:

• PR should be backported to stable branches
• Tested changes locally
• Related to issue set_contact_alias() issue with clients adding it to their Contact #2308

Description

add support for trimming an already existing alias parameter when calling set_contact_alias()

[lgtm-com]

This pull request introduces 1 alert when merging f254478 into 798c1c6 - view on LGTM.com

new alerts:

• 1 for Local variable hides global variable

[miconda]

Thanks!

If nobody has anything against, this can be merged before branching 5.4 to fix the situation of "strange" UA that take the alias from 200ok of REGISTER and use it for subsequent requests. It is an optional function parameter, not changing the existing behaviour when not set.

[miconda]

@eschmidbauer - my comment was to wait a few days before merging to see the opinion of other developers, not to merge. Master is frozen now for new features.

[miconda]

There is also an issue reported by LGTM scanner: 'Local variable hides global variable', see above comments from their bot.

[eschmidbauer]

Apologies, I misunderstood. I can revert the commit

[eschmidbauer]

reverted and resubmitted PR (#2390) with update to address the LGTM scanner issue

[miconda]

A fair amount of time should be allowed for comments, considering time zones, traveling, etc ...

With the revert, I noticed that a new function was actually added to the core. If wanted there, then it should have been a separate commit for it. We want commits per components, so maintainers of each component can see easier their code is affected.

[eschmidbauer]

ive updated the new PR with 2 separate commits, one for core and one for the module