Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "nathelper: add optional set_contact_alias([trim]) parameter" #2389

Merged
merged 1 commit into from Jul 3, 2020
Merged

Revert "nathelper: add optional set_contact_alias([trim]) parameter" #2389

merged 1 commit into from Jul 3, 2020

Conversation

eschmidbauer
Copy link
Contributor

Reverts #2388

@eschmidbauer eschmidbauer merged commit 626fbd0 into master Jul 3, 2020
@eschmidbauer eschmidbauer deleted the revert-2388-nathelper-set_contact_alias-trim branch July 3, 2020 17:26
@henningw
Copy link
Contributor

henningw commented Jul 3, 2020

@eschmidbauer For a revert you can simply use "git revert" on command line or git client, not necessary to create a pull request for this.

@lgtm-com
Copy link

lgtm-com bot commented Jul 3, 2020

This pull request fixes 1 alert when merging 2802bd7 into 339b94c - view on LGTM.com

fixed alerts:

  • 1 for Local variable hides global variable

@eschmidbauer
Copy link
Contributor Author

@eschmidbauer For a revert you can simply use "git revert" on command line or git client, not necessary to create a pull request for this.

thanks! i will remember that going forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eschmidbauer @henningw