Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Ability to utilize alternative binary locations instead of just Oracle #1

Open
crosscontrol opened this issue Nov 8, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@crosscontrol
Copy link

In my opinion it is difficult to figure out what values to put in the variables to download a different jdk version than the default (due to Oracle's site). What do you think of the idea of utilizing alternative binary download locations in addition to the Oracle site. For example, one could utilize the AdoptOpenJDK project's Github published binaries:

https://github.com/AdoptOpenJDK/openjdk11-upstream-binaries/releases

https://adoptopenjdk.net/

Other options include Red Hat or Amazon Corretto.

We could consider the capability to download from any number of sites. I have a couple ideas of how to accomplish this and make it more simple. For example, you could utilize a conditional where if an alternate download file name and url are specified, it utilizes that instead of the Oracle version.

@KAMI911
Copy link
Owner

KAMI911 commented Nov 14, 2019

Dear @crosscontrol!
First of all, thank you for reporting an idea 👍 You are the first issuer 🥇

As you probably know, I already have AdoptOpenJDK role here: https://github.com/KAMI911/ansible-role-java-adopt-open-jdk11

I think it is a great idea to support all common and popular OpenJDK installer in one Ansible Role. What about to introduce java_provider or java_dist variable to select OpenJDK, AdoptOpenJDK and Corretto values? Probably I will not build support for Oracle, since it is hart to test them when Oracle hide the download under a login screen. Of course If someone puts the Oracle JDK installer next to the role it will works. Another idea is to support all of them in separated branches (or repos) and roles. This way is easier to provide download and run feeling on Ansible role (don't have to do minimal configuration, just get the latest LTS version). What do you think about?

@KAMI911 KAMI911 added the enhancement New feature or request label Nov 14, 2019
@crosscontrol
Copy link
Author

Hi @KAMI911,

My pleasure, I try to help when I can. :)

As for the different options, I like your idea of adding variables like that. I think it would be easier to put it into one repository and make the default the OpenJDK version since that will be what most people will want. Then if someone wants another version they can easily configure it and we can include examples on how to do that. Having one repository will hopefully keep it all up to date and reduce maintenance across different repos. I agree about the Oracle JDK.

What do you think?

@KAMI911
Copy link
Owner

KAMI911 commented Nov 2, 2020

I will pick up this issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants