Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bob build should run tsc #71

Closed
n1ru4l opened this issue Jun 21, 2022 · 0 comments · Fixed by #55
Closed

bob build should run tsc #71

n1ru4l opened this issue Jun 21, 2022 · 0 comments · Fixed by #55

Comments

@n1ru4l
Copy link
Collaborator

n1ru4l commented Jun 21, 2022

Right now for a mono repository configuring typescript projects properly and running tsc is mandatory to setup.

For a single package repository running tsc is not mandatory right now, as it uses rollup directly.

We should unify both ways (and remove bundling altogether see #48).

As discussed with @kamilkisiela we wanna do it the following way:

When running bob build it should run tsc and before doing so validate whether the tsconfig is properly set up for what we do.
bob build runs tsc twice. Once for regular commonjs (modules: cjs) and once for esm (modules: node16).
After running tsc bob build should make sure all the files are moved to the right place (e.g. what already happens today).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant