Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage error if __typename is in the query #352

Closed
loremaps opened this issue Jun 14, 2019 · 1 comment · Fixed by #353
Closed

coverage error if __typename is in the query #352

loremaps opened this issue Jun 14, 2019 · 1 comment · Fixed by #353
Labels
🐞 bug Something isn't working 📦 released This issue or pull request is released

Comments

@loremaps
Copy link
Contributor

It seems that coverage throws error if the query contains the field __typename in the following line:

graphql-inspector/packages/core/src/coverage/index.ts

Line 66 in e87c322

coverage.types[parent.name].children[fieldDef.name].locations[

Do you think it is OK to simple ignore it?
@loremaps loremaps mentioned this issue Jun 14, 2019
Merged
@kamilkisiela
Copy link
Owner

I think it's ok

@kamilkisiela kamilkisiela added ⏳ waiting for release This issue or pull request is waiting to be released 🐞 bug Something isn't working 📦 released This issue or pull request is released and removed ⏳ waiting for release This issue or pull request is waiting to be released labels Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug Something isn't working 📦 released This issue or pull request is released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix coverage error if __typename is in the query
2 participants
@kamilkisiela @loremaps