fix the module shutdown order, fixes #533 #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…report the last bit of data before being stopped. Fixes kamon-io#533
|
I'm going to merge this one right away since it is all internal changes only. Coming out in 2.1.4 in a few minutes! |
vishramachandran
added a commit
to filodb/FiloDB
that referenced
this pull request
Jul 23, 2020
This is to uptake Kamon bug fix kamon-io/Kamon#811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, reporters will always get a chance to report the last bit of data before being stopped. Fixes #533.