-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give reporters a final chance to flush data before stopping #533
Comments
Closed
Yeah this is pretty important. I run a lot of kubernetes jobs that just shut jvm down after their are done and metrics are not flushed after Also some monitoring services like Stackdriver doesn't allow for |
ivantopo
added a commit
to ivantopo/Kamon
that referenced
this issue
Jul 22, 2020
…report the last bit of data before being stopped. Fixes kamon-io#533
ivantopo
added a commit
that referenced
this issue
Jul 22, 2020
fix the module shutdown order, fixes #533
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the particular case of all reporters being shut down because of the JVM exiting we should have a means of reporting whatever data has been accumulated since the last tick before completely stopping the reporters. I think the flow should be:
Kamon.stopAllReporters()
is calledreportPeriodSnapshots
/reportSpans
stop
hook is calledThe text was updated successfully, but these errors were encountered: