Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required Package Name #7

Open
ddukki opened this issue Jul 25, 2012 · 2 comments
Open

Required Package Name #7

ddukki opened this issue Jul 25, 2012 · 2 comments
Assignees

Comments

@ddukki
Copy link

ddukki commented Jul 25, 2012

This might not be an issue, but I think it requires documentation. JCL2 requires a package name for loading classes whereas it wasn't required in the original JCL. Code at line 64 in JarClassLoader.java breaks when the class being loaded is not part of a package.

@river-jade
Copy link

+1. This is affecting me as I want to be able to load classes that are in the root package (ie have no package name). I'm happy to submit a pull request if you're happy to look at it.

FWIW the line that's failing for me is actually 264:
String packageName = className.substring( 0, className.lastIndexOf( '.' ) );

Obviously this throws an IndexOutOfBoundsException when there is no package name.

Perhaps the code has moved around somewhat since this issue was opened.

@ghost ghost assigned kamranzafar Nov 7, 2013
@kamranzafar
Copy link
Owner

Will look into it, and include the fix in 2.5 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants