Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance impact when Dianoga OptimizingMediaCache is enabled #82

Closed
kennyschreurs opened this issue Jan 15, 2021 · 2 comments
Closed

Comments

@kennyschreurs
Copy link
Contributor

Version of Dianoga

5.1.0

Environment description

Sitecore 9.0.2 on Azure WebApp S3

What configs you have enabled

Dianoga.DisableForSites
Dianoga.Jpeg
Dianoga.Png
Dianoga.Strategy.MediaCacheAsync

What you expected to see, versus what you actually saw

When we enable Dianoga on our production environment with an empty media cache, we see the CPU and memory consumption of the Azure WebApp go up to 100%. This could be caused by the Dianoga OptimizingMediaCache adding a thread for every non optimized image to a threadpool, and the WebApp is probably suffering from thread starvation causing our site to not respond to requests. Is it possible to implement a TPL to limit the number of concurrent tasks? Instead of passing the optimization process to a threadpool an actionblock could be used to limit the performance impact.

@markgibbons25
Copy link
Collaborator

markgibbons25 commented Jan 17, 2021

Nice idea with the actionblock. Not sure when I'll have time to implement this in the short term so happy to look at any PR.

(Off topic, you could look at for your prod site moving from S3 to Premium V2 / V3, for similar cost you can get better performance.)

@markgibbons25
Copy link
Collaborator

Fixed in 5.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants