guile: fix equality of hash-maps and lists/vectors #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 30, 2015
|
Hmm, that is a bit weird looking. I'm not a guile expert at all (I do Clojure for my day job), but I think syntax-wise it's a clash between the leading underscore (I used for indicating a private function) and dashes which are a common way to separate words in variable and function names. Perhaps defining them as locals within the larger function would allow things to be cleaned up a bit (especially since they aren't likely to be use separately). Want to try that? |
dubek
force-pushed
the
fix-guile-hash-list-equality
branch
from
aeaad35
to
d5995c7
Compare
|
You're right. Fixed. Also using |
kanaka
added a commit
that referenced
this pull request
Nov 30, 2015
guile: fix equality of hash-maps and lists/vectors
|
Yep, looks a lot better. Merged. |
micfan
pushed a commit
to micfan/make-a-lisp
that referenced
this pull request
Nov 8, 2018
guile: fix equality of hash-maps and lists/vectors
luelista
pushed a commit
to luelista/mal
that referenced
this pull request
Mar 10, 2024
guile: fix equality of hash-maps and lists/vectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(As part of #116 and #123)
Probably could use some better scheme styling. For example, maybe
_equal-lists?and_equal-hash-tables?should be defined inside_equal?? I'm not sure what's the best style here. I'll be glad to fix with some directions.