-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular 2 support #289
Comments
Damn... what does this do, out of curiosity? |
I'm not certain since Angular 2 is still very nebulous. The In the Angular design documents there is an I've only seen this new syntax in blog posts such as this one concerning details revealed at ng-europe. |
Bump. now with angular2 being in beta this is a big problem when using |
I know of
using this config:
However, I'm not sure how to handle the case of Angular 2's local variables and templates:
Are we able to allow prefixes without suffixes? I haven't had any progress after several attempts, such as adding |
I didn't try this, but maybe Another idea might be |
Taking the examples from here
|
@duncanbeevers do we still need to implement anything beyond the example above to make Angular 2 work? |
I've documented a configuration that seems to work with Angular2.0.0-beta6 |
@uglow looks the same as the one I gave in #289 (comment) ? Unless they are planning on introducing new syntaxes, I think we have resolved this one. |
@alexlamsl - yes, it is similar to your config but with 2 extra config flags: removeAttributeQuotes and caseSensitive. These flags are also necessary (at least when using |
@alexlamsl shouldn't html-minifier work with this syntax by default without custom workarounds? As far as I know those characters are legal in attributes: https://html.spec.whatwg.org/multipage/syntax.html#attributes-2 |
@andreialecu wow, that's... crazy 🙈 |
@kangax if I am reading what @andreialecu refers to correctly, things like |
Originally we followed HTML4 semantics, which is defined via SGML and lists specific attributes for specific tags. While HTML5 (seems to) specify attribute names more loosely, I still see that validator (https://validator.w3.org/nu/#textarea) complains with I'm guessing if we were to follow HTML5 behavior strictly, we could tolerate things like that (assuming that browsers tolerate them too). |
So AFAIK, after this patch, the current requirement for Angular 2 is:
This test probably then needs to be corrected? As it doesn't look like Angular supports |
Angular 2 adds some new warts to its pseudo-HTML
The text was updated successfully, but these errors were encountered: