Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate snapshot ID in SnapshotInfo #1009

Merged
merged 4 commits into from Jun 2, 2021
Merged

Conversation

PrasadG193
Copy link
Contributor

@PrasadG193 PrasadG193 commented May 26, 2021

Change Overview

Verify Kopia snapshot ID is not empty while marshal, unmarshal SnapshotInfo

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • πŸ› Bugfix
  • 🌻 Feature
  • πŸ—ΊοΈ Documentation
  • πŸ€– Test

Test Plan

  • πŸ’ͺ Manual
  • ⚑ Unit test
  • πŸ’š E2E

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/kopia/utils.go Outdated Show resolved Hide resolved
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@pavannd1 pavannd1 added the kueue label Jun 2, 2021
@mergify mergify bot merged commit 8065055 into master Jun 2, 2021
@mergify mergify bot deleted the kopia-snapshot-validate branch June 2, 2021 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants