Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for file target in kando pull command #1010

Merged
merged 2 commits into from Jun 3, 2021
Merged

Conversation

PrasadG193
Copy link
Contributor

@PrasadG193 PrasadG193 commented May 26, 2021

Change Overview

  • Add support for file target in kando location pull command
  • Create the file if the target doesn't exist

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • πŸ› Bugfix
  • 🌻 Feature
  • πŸ—ΊοΈ Documentation
  • πŸ€– Test

Test Plan

Tested the following cases:

  • Test loc pull with file target where the file already exists and validate the file gets overridden

  • Test loc pull with file target where the file doesn't;t exist and validate that the new file gets created

  • πŸ’ͺ Manual

  • ⚑ Unit test

  • πŸ’š E2E

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@mergify mergify bot merged commit b6be473 into master Jun 3, 2021
@mergify mergify bot deleted the kando-file-target branch June 3, 2021 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants