Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kopia SDK to 5642a8a #1012

Merged
merged 10 commits into from
Jul 28, 2021
Merged

Update kopia SDK to 5642a8a #1012

merged 10 commits into from
Jul 28, 2021

Conversation

ankitjain235
Copy link
Contributor

@ankitjain235 ankitjain235 commented May 28, 2021 •
edited by pavannd1

Change Overview

This PR updates kopia SDK to 5642a8a
There is some refactoring in Kopia for PersistCredentials and it has been moved to internal package. Passing password to functions instead of persisting password.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@ankitjain235 ankitjain235 marked this pull request as ready for review June 2, 2021 13:43
@pavannd1 pavannd1 changed the title Update kopia SDK to 6811f1f Update kopia SDK to 5642a8a Jul 27, 2021
pavannd1
pavannd1 reviewed Jul 27, 2021
View reviewed changes
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase, resolve conflicts and run go mod tidy

pkg/kando/location_pull.go Outdated Show resolved Hide resolved
pkg/kando/location_pull.go Outdated Show resolved Hide resolved
pkg/kando/location_push.go Outdated Show resolved Hide resolved
pkg/kando/location_push.go Outdated Show resolved Hide resolved
pkg/kopia/stream.go Outdated Show resolved Hide resolved
pkg/kopia/stream.go Outdated Show resolved Hide resolved
pavannd1
pavannd1 reviewed Jul 28, 2021
View reviewed changes
pkg/kopia/stream.go Outdated Show resolved Hide resolved
pkg/kando/location_push.go Outdated Show resolved Hide resolved
pavannd1
pavannd1 approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavannd1 pavannd1 added the kueue label Jul 28, 2021
@mergify mergify bot merged commit f79c04b into master Jul 28, 2021
@mergify mergify bot deleted the update-kopia-sdk-latest branch July 28, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ankitjain235 @pavannd1