Azure - Migrate snapshot to a resource group #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onkarbhat
reviewed
Jun 9, 2021
pkg/blockstorage/azure/azuredisk.go
Outdated
| @@ -225,7 +225,12 @@ func (s *AdStorage) SnapshotCopyWithArgs(ctx context.Context, from blockstorage. | |||
| }, | |||
| } | |||
|
|
|||
| result, err := s.azCli.SnapshotsClient.CreateOrUpdate(ctx, s.azCli.ResourceGroup, snapName, createSnap) | |||
| migrateResourceGroup := s.azCli.ResourceGroup | |||
| if val, ok := args[blockstorage.AzureMigrateStorageKey]; ok && val != "" { | |||
There was a problem hiding this comment.
This should be AzureMigrateResourceGroup instead of AzureMigrateStorageKey ?
There was a problem hiding this comment.
you are very correct
bathina2
changed the title
Comment on lines
+229
to
+231
| if val, ok := args[blockstorage.AzureMigrateResourceGroup]; ok && val != "" { | ||
| migrateResourceGroup = val | ||
| } |
There was a problem hiding this comment.
Please add to the function doc comment to describe this key.
| @@ -36,6 +36,7 @@ const ( | |||
| AzureResurceMgrEndpoint = "AZURE_RESOURCE_MANAGER_ENDPOINT" | |||
| AzureMigrateStorageAccount = "AZURE_MIGRATE_STORAGE_ACCOUNT_NAME" | |||
| AzureMigrateStorageKey = "AZURE_MIGRATE_STORAGE_ACCOUNT_KEY" | |||
| AzureMigrateResourceGroup = "AZURE_MIGRATE_RESOURCE_GROUP" | |||
There was a problem hiding this comment.
Shouldn't this be referenced in pkg/blockstorage/blockstorage_test.go?
carlbraganza
requested changes
Jun 11, 2021
That test is skipped. |
carlbraganza
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
The following PR enables Azure to accept a resource group to which a newly create snapshot can belong.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan