Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to Argo Workflow Reference document #1609

Merged
merged 2 commits into from
Sep 1, 2022
Merged

Fixes to Argo Workflow Reference document #1609

merged 2 commits into from
Sep 1, 2022

Conversation

aish-where-ya
Copy link
Contributor

Change Overview

Fixed CR/CRDs and removed the part to submit workflows.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Aug 25, 2022
pavannd1
pavannd1 approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for following up 🎉
LGTM

Kanister automation moved this from In Progress to Reviewer approved Aug 25, 2022
@pavannd1 pavannd1 requested a review from ihcsim August 25, 2022 22:56
@ihcsim
Copy link
Contributor

ihcsim commented Aug 25, 2022

Can merge once CI finished.

@pavannd1 pavannd1 added the kueue label Aug 30, 2022
@mergify mergify bot merged commit 71b59c9 into master Sep 1, 2022
Kanister automation moved this from Reviewer approved to Done Sep 1, 2022
@mergify mergify bot deleted the argo-doc-fixes branch September 1, 2022 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihcsim ihcsim ihcsim approved these changes

@pavannd1 pavannd1 pavannd1 approved these changes

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aish-where-ya @ihcsim @pavannd1