Integration Test - Remove Support for Helm v2 and Provide Support for Enable/Disable wait while Installing Charts

[r4rajat]

Change Overview

Remove Support for Helm v2 and Provide Support for Enable/Disable --wait while Installing Charts

• Add wait as an argument in Install Method present in pkg/helm/client.go and pkg/helm/helm.go
• Add wait=true in apps requiring wait flag while installation

Pull request type

Please check the type of change your PR introduces:

• 🚧 Work in Progress
• 🌈 Refactoring (no functional changes, no api changes)
• 🐹 Trivial/Minor
• 🐛 Bugfix
• 🌻 Feature
• 🗺️ Documentation
• 🤖 Test

Issues

• fixes #issue-number

Test Plan

$ make integration-test

running CMD in the containerized build environment
Running integration tests:
/go/src/github.com/kanisterio/kanister/pkg/testing /go/src/github.com/kanisterio/kanister
go: downloading github.com/pkg/errors v0.9.1
go: downloading k8s.io/api v0.24.3
go: downloading github.com/kastenhq/check v0.0.0-20180626002341-0264cfcea734
go: downloading k8s.io/client-go v0.24.3
go: downloading github.com/jpillora/backoff v1.0.0
go: downloading k8s.io/apimachinery v0.24.3
..
..
..
OK: 6 passed
--- PASS: Test (167.00s)
PASS
ok  	github.com/kanisterio/kanister/pkg/testing	167.037s
/go/src/github.com/kanisterio/kanister

• 💪 Manual
• ⚡ Unit test
• 💚 E2E

[github-actions]

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

[r4rajat]

ok-to-test

[akankshakumari393]

LGTM

[ihcsim]

LGTM - thanks for working on this 👍.

I left a TIOLI comment at pkg/helm/client.go. Feel free to take it or leave it.

Also, I think all the apps should be using NewHelmApp() instead of calling the NewCliClient() directly. But that can be a refactoring for another day.