Revert "Update Cassandra chart version to latest" #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7736794.
ewhamilton
approved these changes
Sep 12, 2020
ewhamilton
reviewed
Sep 12, 2020
pkg/app/cassandra.go
Outdated
| Values: map[string]string{ | ||
| "image.repository": "kanisterio/cassandra", | ||
| "image.repo": "kanisterio/cassandra", |
There was a problem hiding this comment.
Does this need to be image.repository?
There was a problem hiding this comment.
And further checking of #755 shows that image.repo is the correct revert. Removing hold-off label.
There was a problem hiding this comment.
But... this file fail travis because it needs a gofmt.
There was a problem hiding this comment.
I will ask @arush-sal to take a look into this.
|
Travis failing for gofmt on pkg/app/cassandra.go and mongo test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #755. This is breaking in the pipeline